-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX: Multichain: Add separator under 'View on Explorer' #21223
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
vthomas13
approved these changes
Oct 6, 2023
darkwing
added
team-extension-ux
DEPRECATED: please use "team-wallet-ux" label instead
needs-ux-ds-review
labels
Oct 6, 2023
brad-decker
approved these changes
Oct 6, 2023
Builds ready [7edf1e1]
Page Load Metrics (1316 ± 347 ms)
Bundle size diffs
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #21223 +/- ##
========================================
Coverage 68.61% 68.61%
========================================
Files 1017 1017
Lines 40814 40814
Branches 10900 10900
========================================
Hits 28002 28002
Misses 12812 12812
☔ View full report in Codecov by Sentry. |
metamaskbot
added
the
release-11.4.0
Issue or pull request that will be included in release 11.4.0
label
Oct 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.4.0
Issue or pull request that will be included in release 11.4.0
team-extension-ux
DEPRECATED: please use "team-wallet-ux" label instead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a separator to the Multichain global menu under View on Explorer
Manual testing steps
Screenshots/Recordings
Related issues
Fixes: #21220
This issue also references the position of the Account Picker but that is addressed in #21220
Pre-merge author checklist
Pre-merge reviewer checklist