Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Multichain: Add separator under 'View on Explorer' #21223

Merged
merged 8 commits into from
Oct 10, 2023

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Oct 6, 2023

Description

This PR adds a separator to the Multichain global menu under View on Explorer

Manual testing steps

  1. Open the Global Menu
  2. See the separator between View on Explorer and its next menu item

Screenshots/Recordings

SCR-20231005-txgc

Related issues

Fixes: #21220

This issue also references the position of the Account Picker but that is addressed in #21220

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner October 6, 2023 04:04
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing added team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead needs-ux-ds-review labels Oct 6, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [7edf1e1]
Page Load Metrics (1316 ± 347 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint852001042713
domContentLoaded701931002713
load8122131316723347
domInteractive701931002713
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 135 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f80569a) 68.61% compared to head (7edf1e1) 68.61%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21223   +/-   ##
========================================
  Coverage    68.61%   68.61%           
========================================
  Files         1017     1017           
  Lines        40814    40814           
  Branches     10900    10900           
========================================
  Hits         28002    28002           
  Misses       12812    12812           
Files Coverage Δ
...i/components/multichain/global-menu/global-menu.js 62.07% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darkwing darkwing merged commit a6f058f into develop Oct 10, 2023
64 checks passed
@darkwing darkwing deleted the 1389-global-menu-separator branch October 10, 2023 17:12
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
@metamaskbot metamaskbot added the release-11.4.0 Issue or pull request that will be included in release 11.4.0 label Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.4.0 Issue or pull request that will be included in release 11.4.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants