Remove identities associated to the hardware keyring when forgetting the device

[montelaidev]

Description

This pr fixes the issue where the identities of a hardware wallet were not removed when removing the device.

Related issues

Fixes: #21742

Manual testing steps

1. Connect a ledger
2. Add a ledger account
3. Go to connect a ledger again
4. Click on forget device
5. Check to see the ledger account was removed from the UI

Screenshots/Recordings

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8488e7a) 68.59% compared to head (70fdab5) 68.60%.
Report is 17 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #21755      +/-   ##
===========================================
+ Coverage    68.59%   68.60%   +0.01%     
===========================================
  Files         1046     1046              
  Lines        41613    41616       +3     
  Branches     11110    11112       +2     
===========================================
+ Hits         28543    28548       +5     
+ Misses       13070    13068       -2     

Files	Coverage Δ
app/scripts/controllers/preferences.js	55.48% <ø> (-0.29%)	⬇️
app/scripts/metamask-controller.js	55.31% <66.67%> (+0.20%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [fb12a36]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (535 ± 266 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	84	123	98	11	6
		domContentLoaded	66	120	85	15	7
		load	79	1497	535	554	266
		domInteractive	66	120	85	15	7

Bundle size diffs [🚀 Bundle size reduced!]

• background: -102 Bytes (-0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[gantunesr]

LGTM. Just left a couple of comments

Edit: I also tested the branch and the functionality is correct

[metamaskbot]

Builds ready [70fdab5]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (493 ± 326 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	93	137	113	13	6
		domContentLoaded	70	126	94	16	8
		load	82	1786	493	678	326
		domInteractive	70	126	94	16	8

Bundle size diffs [🚀 Bundle size reduced!]

• background: -102 Bytes (-0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[plasmacorral]

Tested on Mac Sonoma 14 in Chrome 117.0.5938.92 with Ledger, Trezor and Keystone. Also tested Firefox version 118.0.2 with both Keystone and Trezor. Able to remove accounts, forget devices and re-add the hardware address. Did not have access to Lattice at the time of testing.