New Settings: Show extension in full size view #22383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
dan437
force-pushed
the
full-size-view
branch
2 times, most recently
from
c33cd4a
to
fcd5fdf
Compare
dan437
added
release-11.9.0
dan437
force-pushed
the
full-size-view
branch
2 times, most recently
from
17733e5
to
4b59fc0
Compare
dan437
added
team-swaps
and removed
INVALID-PR-TEMPLATE
|
Great feature addition! |
|
LGTM ! Just need to update the snapshot for e2e test One question: is it possible to append some e2e tests for this new feature ? |
digiwand
reviewed
Jan 10, 2024
| @@ -13,6 +13,7 @@ import { | |||
| setFeatureFlag, | |||
| setShowFiatConversionOnTestnetsPreference, | |||
| setShowTestNetworks, | |||
| setShowExtensionInFullSizeView, | |||
There was a problem hiding this comment.
[super nit] placement breaks alphabetical prop ordering here and other places above
dan437
force-pushed
the
full-size-view
branch
6 times, most recently
from
1b5d411
to
0661b11
Compare
What's New - Extension Full Size View Advanced Setting (#22369)
dan437
force-pushed
the
full-size-view
branch
from
3ed1af1
to
759cbd0
Compare
DDDDDanica
approved these changes
Jan 12, 2024
Builds ready [759cbd0]
Page Load Metrics (1327 ± 138 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are people who love to use the extension in the full size view. It's a bit time consuming to always click in the extension on three dots and then on Expand view. With this new setting the extension will open in the full size view after clicking on the extension icon (except if a 3rd party opens it, e.g. signing a Swap on Uniswap with MetaMask).
Screenshots/Recordings
Testing