Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's New - Extension Full Size View Advanced Setting #22369

Merged
merged 7 commits into from
Dec 21, 2023

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Dec 21, 2023

Description

  • adds mention of Full-size View Setting in What's New popup modal
  • supports searching for the setting
  • note: image used is a reused image - app/images/onboarding-pin-browser.svg

Related issues

Fixes: #

Manual testing steps

  1. Open a new instance of MM to ensure the notifications are set to not viewed
  2. Open application in pop-up or home.html to see new What's App notification

Screenshots/Recordings

Expanded View

Screenshot 2023-12-21 at 8 03 22 AM Screenshot 2023-12-21 at 8 03 45 AM

Pop-up View

Screenshot 2023-12-21 at 8 02 59 AM Screenshot 2023-12-21 at 8 04 36 AM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@digiwand digiwand requested a review from dan437 December 21, 2023 02:50
@digiwand digiwand changed the title What's New - Full-size / Fullscreen Mode support What's New - Extension Full Size View Advanced Setting Dec 21, 2023
@dan437 dan437 marked this pull request as ready for review December 21, 2023 16:20
@dan437 dan437 requested a review from a team as a code owner December 21, 2023 16:20
@dan437 dan437 merged commit 8b34c60 into full-size-view Dec 21, 2023
55 of 63 checks passed
@dan437 dan437 deleted the full-size-view-whats-new branch December 21, 2023 16:22
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants