Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move native token value below Fiat within Token list #22601

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

vthomas13
Copy link
Contributor

Description

We want to be more consistent in the way we show fiat values across different components, as well as aligning with mobile UX.
This PR shifts the token value to the right side of the cell, and replaces the old native token value with the full name of the token.
We also round token balances to 5 decimal places to prevent overflow now.

Related issues

Fixes: #21132

Manual testing steps

  1. Go to extension Tokens Listing screen
  2. Verify that cells have Token Symbol in top left, Token Name in bottom left
  3. Verify that cells have Primary Currency in the top right, and Secondary currency in the bottom right
  4. Verify that native token balances are rounded to 5 decimal places

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vthomas13 vthomas13 requested a review from a team as a code owner January 18, 2024 20:03
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vthomas13 vthomas13 added team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead needs-ux-ds-review labels Jan 18, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [0e98a71]
Page Load Metrics (1341 ± 160 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint832791916933
domContentLoaded9191777536
load77318931341333160
domInteractive9191777536
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 813 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@vthomas13 vthomas13 merged commit 3456529 into develop Jan 23, 2024
49 of 71 checks passed
@vthomas13 vthomas13 deleted the move-native-tokenbal branch January 23, 2024 22:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
@metamaskbot metamaskbot added the release-11.10.0 Issue or pull request that will be included in release 11.10.0 label Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.10.0 Issue or pull request that will be included in release 11.10.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move native token value below Fiat within Token list
4 participants