Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move native token value below Fiat within Token list #22200

Closed
wants to merge 3 commits into from

Conversation

vthomas13
Copy link
Contributor

@vthomas13 vthomas13 commented Dec 7, 2023

Description

We want to be more consistent in the way we show fiat values across different components, as well as aligning with mobile UX.
This PR shifts the token value to the right side of the cell, and replaces the old native token value with the full name of the token.

Related issues

Fixes: #21132

Manual testing steps

  1. Go to extension Tokens Listing screen
  2. Verify that cells have Token Symbol in top left, Token Name in bottom left
  3. Verify that cells have Primary Currency in the top right, and Secondary currency in the bottom right

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Dec 7, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (fc724d6) 67.80% compared to head (584a95e) 67.80%.

Files Patch % Lines
...ents/multichain/token-list-item/token-list-item.js 54.55% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #22200   +/-   ##
========================================
  Coverage    67.80%   67.80%           
========================================
  Files         1058     1058           
  Lines        40977    40980    +3     
  Branches     10992    10993    +1     
========================================
+ Hits         27783    27786    +3     
  Misses       13194    13194           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vthomas13 vthomas13 added team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead needs-ux-ds-review labels Dec 11, 2023
@vthomas13 vthomas13 marked this pull request as ready for review December 11, 2023 21:49
@vthomas13 vthomas13 requested a review from a team as a code owner December 11, 2023 21:51
@vthomas13 vthomas13 marked this pull request as draft January 9, 2024 20:12
@vthomas13 vthomas13 closed this Jan 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
@vthomas13
Copy link
Contributor Author

Had to clean up the branch here
#22601

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move native token value below Fiat within Token list
1 participant