-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add custom network modal form #25213
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
1e8a7de
to
0c41cf3
Compare
Builds ready [1e8a7de]
Page Load Metrics (236 ± 268 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25213 +/- ##
===========================================
- Coverage 65.40% 65.38% -0.01%
===========================================
Files 1382 1382
Lines 54736 54765 +29
Branches 14353 14367 +14
===========================================
+ Hits 35795 35807 +12
- Misses 18941 18958 +17 ☔ View full report in Codecov by Sentry. |
Builds ready [1e8a7de]
Page Load Metrics (236 ± 268 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [1e8a7de]
Page Load Metrics (236 ± 268 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
6f35f63
to
3c4cb01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worked locally, was able to add a new network from the modal
0c41cf3
to
fbd6e17
Compare
de40a51
to
b71e51e
Compare
d200bcc
to
11e0b77
Compare
2cb64d3
to
2db5534
Compare
3edd3fa
to
b10510e
Compare
Builds ready [2aa6a48]
Page Load Metrics (126 ± 156 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [2aa6a48]
Page Load Metrics (126 ± 156 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
the custom add network form flow is now available on the modal
Related issues
Fixes:
Manual testing steps
yarn && ENABLE_NETWORK_UI_REDESIGN=1 yarn start
7.click on add network ( you should see the network form )
Screenshots/Recordings
Before
before-add.mov
After
custom-add-afer.mov
Pre-merge author checklist
Pre-merge reviewer checklist