Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ZeroNet #7038

Merged
merged 4 commits into from
Oct 31, 2019
Merged

Add support for ZeroNet #7038

merged 4 commits into from
Oct 31, 2019

Conversation

filips123
Copy link
Contributor

@filips123 filips123 commented Aug 19, 2019

Add support for ZeroNet site address in ENS domains. This depends on pldespaigne/content-hash#33 and it is related to ensdomains/ui#23. Changes in content-hash are now released in 2.4.4.

@Gudahtt
Copy link
Member

Gudahtt commented Sep 19, 2019

The PR this depends on was now closed: pldespaigne/content-hash#33

I'm guessing this PR won't work until content-hash is updated to v2.4.4.

@filips123
Copy link
Contributor Author

@Gudahtt Changes from that Pr were implemented in a slightly different way. Yes, content-hash needs to be updated to v2.4.4. I will update it soon.

@filips123
Copy link
Contributor Author

filips123 commented Sep 19, 2019

@Gudahtt I updated content-hash to 2.4.4. However, for some reason, I can't update lock file with Yarn, so I only updated package.json (this is why CI failed). You can now merge this PR and update lock file.

@Gudahtt
Copy link
Member

Gudahtt commented Sep 25, 2019

@filips123 I've just rebased this and updated the lock file.

How would we go about testing this? Would you mind testing this latest version? I'm not familiar with ZeroNet

@filips123
Copy link
Contributor Author

@Gudahtt What testing should this be?

ZeroNet works so that the website is accessed at http://127.0.0.1:43110/ADDRESS/PATH (similar to IPFS and Swarm gateways). Here, address is stored in ENS domain as content-hash and path is from the original URL. So, it should work correctly.

Testing on actual domains would be a bit harder because there are currently no ZeroNet ENS domains, and ENS manager PR is currently still not merged.

@danjm danjm added this to the UI Sprint 23 milestone Oct 28, 2019
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to merge this for now, but going forward we may ask that anybody adding additional protocols to the ENS resolver wait for the plugin system, and implement it as a plugin.

We do want to support EIP-1577, but we're not eager to take on the maintenance burden of supporting every possible protocol that an ENS name could map to. Plugins would allow us to safely accept additional protocols maintained by third parties, and it would also allow users to disable protocols if they'd prefer. We will likely migrate these existing protocols to plugins as well.

@Gudahtt Gudahtt merged commit 3060632 into MetaMask:develop Oct 31, 2019
@filips123
Copy link
Contributor Author

@Gudahtt Thank you! Do you also have any evidence when my ENS Manager PR (ensdomains/ui#23) will be merged? Because without it, there isn't any easy way to create such domains (although you can programatically manually register it with Web3 librrary).

@Gudahtt
Copy link
Member

Gudahtt commented Oct 31, 2019

Unfortunately not! I'm not involved with that library. Best of luck getting that merged though.

@filips123
Copy link
Contributor Author

Ok, thanks anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants