Report missing en locale messages to Sentry
#7197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
sentry-report-missing-en-locale-messages
branch
from
4e6557e
to
2b5c8fc
Compare
Any missing messages in the `en` locale are now reported to Sentry as errors. They are printed to the console as an error upon the first encounter as well. If a missing message is found during e2e testing, the error is thrown. This will likely break the e2e test even if it isn't looking for console errors, as the UI with the missing message will fail to render. The `tOrDefault` method was updated to no longer attempt looking for messages with a key that is a falsey value (e.g. `undefined`). There are a few places where they key is determined dynamically, where it's expected during the normal flow for it to be `undefined` sometimes. In these cases we don't want the error to be thrown.
Gudahtt
force-pushed
the
sentry-report-missing-en-locale-messages
branch
from
2b5c8fc
to
98872b0
Compare
Builds ready [98872b0]
|
|
I'm not sure what to make of that Coveralls failed status check 😕 I've never seen that before. It looks like the coverage was reported correctly. It's even showing up on the Coveralls details page (under "SOURCE FILES ON BUILD 107121"). |
|
Yeah I don't know what to make of this either. Maybe try triggering a re-test with a nullish change? |
Builds ready [98872b0]
|
danfinlay
approved these changes
Sep 19, 2019
danjm
approved these changes
Sep 21, 2019
Gudahtt
added a commit
to Gudahtt/metamask-extension
that referenced
this pull request
Sep 27, 2019
* origin/develop: (56 commits) Add advanced setting to enable editing nonce on confirmation screens (MetaMask#7089) Add migration on 3box imports and remove feature flag (MetaMask#7209) ci - install deps - limit install scripts to whitelist (MetaMask#7208) Add a/b test for full screen transaction confirmations (MetaMask#7162) Update minimum Firefox verison to 56.0 (MetaMask#7213) mesh-testing - submit infura rpc requests to mesh-testing container (MetaMask#7031) obs-store/local-store should upgrade webextension error to real error (MetaMask#7207) sesify-viz - bump dep for visualization enhancement (MetaMask#7175) address book entries by chainId (MetaMask#7205) Optimize images only during production build (MetaMask#7194) Use common test build during CI (MetaMask#7196) Report missing `en` locale messages to Sentry (MetaMask#7197) Verify locales on CI (MetaMask#7199) updated ganache and addons-linter (MetaMask#7204) fixup! add user rejected errors add user rejected errors update json-rpc-engine use eth-json-rpc-errors Remove unused locale messages (MetaMask#7190) Remove unused components (MetaMask#7191) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any missing messages in the
enlocale are now reported to Sentry as errors. They are printed to the console as an error upon the first encounter as well.If a missing message is found during e2e testing, the error is thrown. This will likely break the e2e test even if it isn't looking for console errors, as the UI with the missing message will fail to render.
The
tOrDefaultmethod was updated to no longer attempt looking for messages with a key that is a falsey value (e.g.undefined). There are a few places where they key is determined dynamically, where it's expected during the normal flow for it to beundefinedsometimes. In these cases we don't want the error to be thrown.