Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration on 3box imports and remove feature flag #7209

Merged
merged 10 commits into from
Sep 26, 2019
Merged

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Sep 23, 2019

This PR makes two notable changes:

  • Updates the threebox controller so that data retrieved from threebox is run through new migrations before it is restored to metamask
  • removes the 3box feature flag

@metamaskbot
Copy link
Collaborator

Builds ready [03820be]

@metamaskbot
Copy link
Collaborator

Builds ready [63bfef2]

@metamaskbot
Copy link
Collaborator

Builds ready [2cddae3]

@metamaskbot
Copy link
Collaborator

Builds ready [12ccac3]

@metamaskbot
Copy link
Collaborator

Builds ready [c21d1cc]

Gudahtt
Gudahtt previously approved these changes Sep 26, 2019
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@metamaskbot
Copy link
Collaborator

Builds ready [461a504]

@danjm danjm merged commit 970e90e into develop Sep 26, 2019
@metamaskbot
Copy link
Collaborator

Builds ready [461a504]

Gudahtt added a commit to Gudahtt/metamask-extension that referenced this pull request Sep 27, 2019
* origin/develop: (56 commits)
  Add advanced setting to enable editing nonce on confirmation screens (MetaMask#7089)
  Add migration on 3box imports and remove feature flag (MetaMask#7209)
  ci - install deps - limit install scripts to whitelist (MetaMask#7208)
  Add a/b test for full screen transaction confirmations (MetaMask#7162)
  Update minimum Firefox verison to 56.0 (MetaMask#7213)
  mesh-testing - submit infura rpc requests to mesh-testing container (MetaMask#7031)
  obs-store/local-store should upgrade webextension error to real error (MetaMask#7207)
  sesify-viz - bump dep for visualization enhancement (MetaMask#7175)
  address book entries by chainId (MetaMask#7205)
  Optimize images only during production build (MetaMask#7194)
  Use common test build during CI (MetaMask#7196)
  Report missing `en` locale messages to Sentry (MetaMask#7197)
  Verify locales on CI (MetaMask#7199)
  updated ganache and addons-linter (MetaMask#7204)
  fixup! add user rejected errors
  add user rejected errors
  update json-rpc-engine
  use eth-json-rpc-errors
  Remove unused locale messages (MetaMask#7190)
  Remove unused components (MetaMask#7191)
  ...
@whymarrh whymarrh deleted the 3box-updates branch October 2, 2019 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants