Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gulp-rename from v1.4.0 to v2.0.0 #9112

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jul 30, 2020

The changes between these versions don't affect us. The breaking change was related to passing in a function to gulp-rename, which we don't do.

The changes between these versions don't affect us. The breaking change
was related to passing in a function to `gulp-rename`, which we don't
do.
@Gudahtt Gudahtt marked this pull request as ready for review July 30, 2020 17:42
@Gudahtt Gudahtt requested a review from a team as a code owner July 30, 2020 17:42
@metamaskbot
Copy link
Collaborator

Builds ready [d86968d]
Page Load Metrics (548 ± 71 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29493863
domContentLoaded32373154614770
load32573354814771
domInteractive32373054614770

@Gudahtt Gudahtt merged commit ee291d4 into develop Jul 30, 2020
@Gudahtt Gudahtt deleted the update-gulp-rename branch July 30, 2020 17:55
Gudahtt added a commit that referenced this pull request Jul 30, 2020
* origin/develop:
  Factor out `getEnvironment` function in build script (#9114)
  Update `browserify` from v16.2.3 to v16.5.1 (#9113)
  Update `sesify-viz` from v3.0.9 to v3.0.10 (#9111)
  Update `gulp-rename` from v1.4.0 to v2.0.0 (#9112)
  Update `source-map-explorer` from v2.0.1 to v2.4.2 (#9110)
  Add `build-artifacts` to .gitignore (#9109)
Gudahtt added a commit that referenced this pull request Aug 7, 2020
The changes between these versions don't affect us. The breaking change
was related to passing in a function to `gulp-rename`, which we don't
do.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants