Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build-artifacts to .gitignore #9109

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jul 30, 2020

The build-artifacts directory is created on CI (as of #7151), and is used to store the sesify visualization and dependency logs. It's useful to have this ignored locally as well, for when those scripts are being tested.

The `build-artifacts` directory is created on CI (as of #7151), and is
used to store the sesify visualization and dependency logs. It's useful
to have this ignored locally as well, for when those scripts are being
tested.
@Gudahtt Gudahtt requested a review from a team as a code owner July 30, 2020 16:32
@metamaskbot
Copy link
Collaborator

Builds ready [6ba11ed]
Page Load Metrics (597 ± 92 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaintNaNNaNNaNNaNNaN
domContentLoaded322107359519091
load326107559719192
domInteractive322107359419091

@Gudahtt Gudahtt merged commit d832b98 into develop Jul 30, 2020
@Gudahtt Gudahtt deleted the add-build-artifacts-to-gitignore branch July 30, 2020 16:56
Gudahtt added a commit that referenced this pull request Jul 30, 2020
* origin/develop:
  Factor out `getEnvironment` function in build script (#9114)
  Update `browserify` from v16.2.3 to v16.5.1 (#9113)
  Update `sesify-viz` from v3.0.9 to v3.0.10 (#9111)
  Update `gulp-rename` from v1.4.0 to v2.0.0 (#9112)
  Update `source-map-explorer` from v2.0.1 to v2.4.2 (#9110)
  Add `build-artifacts` to .gitignore (#9109)
Gudahtt added a commit that referenced this pull request Aug 7, 2020
The `build-artifacts` directory is created on CI (as of #7151), and is
used to store the sesify visualization and dependency logs. It's useful
to have this ignored locally as well, for when those scripts are being
tested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants