Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out getEnvironment function in build script #9114

Merged
merged 1 commit into from Jul 30, 2020

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jul 30, 2020

There are no functional changes. This was extracted from #8170

There are no functional changes. This was extracted from #8170
@Gudahtt Gudahtt requested review from kumavis and a team as code owners July 30, 2020 18:52
@metamaskbot
Copy link
Collaborator

Builds ready [bce8340]
Page Load Metrics (539 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint298243168
domContentLoaded30166353712761
load30266453912661
domInteractive30066353712761

@Gudahtt Gudahtt merged commit 9e12cdc into develop Jul 30, 2020
@Gudahtt Gudahtt deleted the factor-out-get-environment-function branch July 30, 2020 19:19
Gudahtt added a commit that referenced this pull request Jul 30, 2020
* origin/develop:
  Factor out `getEnvironment` function in build script (#9114)
  Update `browserify` from v16.2.3 to v16.5.1 (#9113)
  Update `sesify-viz` from v3.0.9 to v3.0.10 (#9111)
  Update `gulp-rename` from v1.4.0 to v2.0.0 (#9112)
  Update `source-map-explorer` from v2.0.1 to v2.4.2 (#9110)
  Add `build-artifacts` to .gitignore (#9109)
Gudahtt added a commit that referenced this pull request Aug 7, 2020
There are no functional changes. This was extracted from #8170
Gudahtt added a commit that referenced this pull request Aug 10, 2020
* origin/master: (44 commits)
  Add category in eventOpts (#9164)
  Update changelog for v8.0.7 (#9161)
  Version v8.0.7
  Remove web3 e2e tests (#9159)
  Add web3 usage metrics, prepare for web3 removal (#9144)
  Use `pathname` instead of URL for `currentPath` metrics parameter (#9158)
  Remove `url` parameter from `metricsEvent` (#9157)
  Change MetaMetrics category for background events (#9155)
  remove .network-name height
  Use luxon@1.24.1 (#9154)
  Update 'react-devtools' to ^4.8.0 (#9140)
  Fix connection removal bug (#9137)
  Add source map validator to CI (#9135)
  Update source map validator target files (#9133)
  Improve sourcemap validator console report (#9131)
  Add `validate-source-maps` npm script (#9134)
  Non-zero exit code upon failure to validate source maps (#9132)
  Update `brfs` from v1.6.1 to v2.0.2 (#9115)
  Factor out `getEnvironment` function in build script (#9114)
  Update `browserify` from v16.2.3 to v16.5.1 (#9113)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants