Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'react-devtools' to ^4.8.0 #9140

Merged
merged 2 commits into from Aug 6, 2020

Conversation

tmashuang
Copy link
Contributor

One noticeable fix is the ability to resize the standalone app.

@tmashuang tmashuang requested a review from a team as a code owner August 6, 2020 01:02
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think there might be some uncommitted lockfile changes here.

Would you mind running yarn and seeing if there are any extra changes?

@tmashuang
Copy link
Contributor Author

There were, just didn't know if they were relevant or not, so I redacted them. Will provide them.

@tmashuang tmashuang dismissed whymarrh’s stale review August 6, 2020 18:59

Full yarn lock changes in d0c0297

@tmashuang tmashuang requested a review from whymarrh August 6, 2020 19:00
@whymarrh
Copy link
Contributor

whymarrh commented Aug 6, 2020

I'm not sure why the build is failing from a quick look, want to try rebasing this on the latest develop?

@tmashuang
Copy link
Contributor Author

tmashuang commented Aug 6, 2020

Pretty sure it was me pushing the branch to this repo then deleting, even though the head is from my fork, tangling up the CI. I'll resolve.

Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tmashuang tmashuang merged commit 9e1aed8 into MetaMask:develop Aug 6, 2020
@tmashuang tmashuang deleted the bump-react-devtools branch August 6, 2020 19:30
Gudahtt pushed a commit that referenced this pull request Aug 7, 2020
* bump-react-devtools

* Completed yarn lock after version bump of react-devtools
Gudahtt added a commit that referenced this pull request Aug 10, 2020
* origin/master: (44 commits)
  Add category in eventOpts (#9164)
  Update changelog for v8.0.7 (#9161)
  Version v8.0.7
  Remove web3 e2e tests (#9159)
  Add web3 usage metrics, prepare for web3 removal (#9144)
  Use `pathname` instead of URL for `currentPath` metrics parameter (#9158)
  Remove `url` parameter from `metricsEvent` (#9157)
  Change MetaMetrics category for background events (#9155)
  remove .network-name height
  Use luxon@1.24.1 (#9154)
  Update 'react-devtools' to ^4.8.0 (#9140)
  Fix connection removal bug (#9137)
  Add source map validator to CI (#9135)
  Update source map validator target files (#9133)
  Improve sourcemap validator console report (#9131)
  Add `validate-source-maps` npm script (#9134)
  Non-zero exit code upon failure to validate source maps (#9132)
  Update `brfs` from v1.6.1 to v2.0.2 (#9115)
  Factor out `getEnvironment` function in build script (#9114)
  Update `browserify` from v16.2.3 to v16.5.1 (#9113)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants