Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version v8.0.8 RC #9240

Merged
merged 6 commits into from Aug 14, 2020
Merged

Version v8.0.8 RC #9240

merged 6 commits into from Aug 14, 2020

Conversation

metamaskbot
Copy link
Collaborator

@metamaskbot metamaskbot commented Aug 14, 2020 •
edited by Gudahtt

  • #9211: Fix Etherscan redirect on notification click
  • #9237: Reduce volume of web3 usage metrics
  • #9227: Permit all-caps addresses

Gudahtt and others added 3 commits August 14, 2020 19:05
@Gudahtt
Add version dimension to background metrics (#9167)
4d499cc 
The background metrics were missing the `version` custom dimension. It
has now been added to all background metric events.
@PatrykLucka @Gudahtt
Fix Etherscan redirect on notification click (#9211)
74decc3
@Gudahtt
Send web3 usage metrics once per origin/property (#9237)
d49c444 
The usage metrics for the injected web3 instance were being sent upon
each use, which exceeded the limits of our Matomo plan. These metrics
are now only being sent upon the first usage, for each origin and
property.
@metamaskbot metamaskbot requested a review from a team as a code owner August 14, 2020 22:38
PatrykLucka and others added 2 commits August 14, 2020 19:39
@PatrykLucka @Gudahtt
Permit all-caps addresses (#9227)
e47774d 
* permit all-caps addresses

* handle empty address
@metamaskbot @Gudahtt
Version v8.0.8
5db866b
@Gudahtt Gudahtt marked this pull request as draft August 14, 2020 22:46
@metamaskbot
Copy link
Collaborator Author

Builds ready [5db866b]
Page Load Metrics (631 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaintNaNNaNNaNNaNNaN
domContentLoaded333100362916479
load334100563116579
domInteractive332100362916479

@Gudahtt Gudahtt marked this pull request as ready for review August 14, 2020 23:05
@metamaskbot
Copy link
Collaborator Author

Builds ready [e8a468a]
Page Load Metrics (585 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28473552
domContentLoaded3336835849244
load3356845859244
domInteractive3336825839244

@Gudahtt Gudahtt merged commit eab1add into master Aug 14, 2020
@Gudahtt Gudahtt deleted the Version-v8.0.8 branch August 14, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

@rekmarks rekmarks Awaiting requested review from rekmarks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@metamaskbot @whymarrh @Gudahtt @PatrykLucka