Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix some TS errors in component library #10307

Merged
merged 35 commits into from
Aug 12, 2024
Merged

chore: Fix some TS errors in component library #10307

merged 35 commits into from
Aug 12, 2024

Conversation

kylanhurt
Copy link
Contributor

@kylanhurt kylanhurt commented Jul 15, 2024 •
edited
Loading

Description

Purpose of this task is to remove many of the Typescript errors from within the app/component-library folder.

Related issues

Fixes: #10200

Manual testing steps

  1. Go to tsconfig.lint.json
  2. Uncomment the // "app/component-library/**/*", line
  3. yarn lint:tsc
  4. See if any errors show up from the app/component files

Screenshots/Recordings

Before

image

After

No errors from those files

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@kylanhurt kylanhurt added team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 16, 2024
@kylanhurt kylanhurt added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 16, 2024
@kylanhurt kylanhurt marked this pull request as ready for review July 16, 2024 20:49
@kylanhurt kylanhurt requested review from a team as code owners July 16, 2024 20:49
kylanhurt
kylanhurt commented Jul 17, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@MetaMask MetaMask deleted a comment from github-actions bot Jul 18, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Jul 18, 2024
@kylanhurt kylanhurt added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 31, 2024
brianacnguyen
brianacnguyen previously approved these changes Jul 31, 2024
View reviewed changes
@kylanhurt kylanhurt added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2e9d85e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bd0da1c6-63f5-4328-85a3-1d868ac32ff6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@kylanhurt
Copy link
Contributor Author

Can we add to the PR description why reanimated version update was needed?

I just reverted it. Turns out we didn't need to update the package after all

@kylanhurt kylanhurt added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ab10103
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9042ad00-08dc-473f-970b-a7c56de64700

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

tommasini
tommasini reviewed Aug 2, 2024
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 12, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3924a76
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cfc2ef3a-9723-4db4-93e9-2691e1f0f359

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kylanhurt kylanhurt merged commit 3891c6e into main Aug 12, 2024
33 checks passed
@kylanhurt kylanhurt deleted the kylan/tsc-lint-1 branch August 12, 2024 21:37
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2024
@metamaskbot metamaskbot added the release-7.30.0 Issue or pull request that will be included in release 7.30.0 label Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@brianacnguyen brianacnguyen brianacnguyen left review comments

Assignees

@kylanhurt kylanhurt

Labels
release-7.30.0 Issue or pull request that will be included in release 7.30.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform type-tech-debt Technical debt
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chore: Typescript type coverage component-library folder
6 participants
@kylanhurt @brianacnguyen @tommasini @gauthierpetetin @sethkfman @metamaskbot