-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Added parse errors to be caught on vault corruption flow #10481
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise❌❌❌ Commit hash: e71e075 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bitrise✅✅✅ Commit hash: f53a92e Note
|
Quality Gate passedIssues Measures |
Description
Added parse errors to be caught on vault corruption flow
This was tested by throwing an error on UserEntryAuth function like this:
This way was possible to replicate the JSON Parse error identified here
Screen.Recording.2024-07-30.at.19.10.18.mov
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist