Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: TS coverage UI folder part 1 #10537

Merged
merged 19 commits into from
Aug 13, 2024
Merged

chore: TS coverage UI folder part 1 #10537

merged 19 commits into from
Aug 13, 2024

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Aug 2, 2024 •
edited
Loading

Description

Before:
Found 724 errors in 201 files.

After:
Found 462 errors in 134 files.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini linked an issue Aug 2, 2024 that may be closed by this pull request
Chore: Typescript type coverage UI Folder part 1 #10202
Closed
9 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini marked this pull request as ready for review August 12, 2024 15:41
@tommasini tommasini requested a review from a team as a code owner August 12, 2024 15:41
@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 12, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4928f16
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c9a1555c-f756-4389-b583-d1b722cdbf45

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini linked an issue Aug 13, 2024 that may be closed by this pull request
Chore: Typescript type coverage UI Folder part 2 #10203
Closed
9 tasks
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.92593% with 20 lines in your changes missing coverage. Please review.

Project coverage is 51.05%. Comparing base (de5ca5f) to head (ea3574a).
Report is 13 commits behind head on main.

Files Patch % Lines
app/components/UI/QRHardware/QRSigningDetails.tsx 0.00% 10 Missing ⚠️
app/components/UI/AssetOverview/AssetOverview.tsx 0.00% 3 Missing ⚠️
app/components/UI/AssetOverview/Price/Price.tsx 0.00% 2 Missing ⚠️
app/components/UI/OnboardingWizard/index.tsx 50.00% 2 Missing ⚠️
...ddToAddressBookWrapper/AddToAddressBookWrapper.tsx 50.00% 0 Missing and 1 partial ⚠️
...ponents/UI/HardwareWallet/AccountDetails/index.tsx 0.00% 1 Missing ⚠️
...onents/UI/HardwareWallet/AccountSelector/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10537      +/-   ##
==========================================
+ Coverage   51.03%   51.05%   +0.02%     
==========================================
  Files        1517     1518       +1     
  Lines       36284    36304      +20     
  Branches     4199     4201       +2     
==========================================
+ Hits        18518    18536      +18     
  Misses      16560    16560              
- Partials     1206     1208       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 13, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5435e56
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e863df14-08fc-4b89-971b-283446b59b62

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L
Cal-L previously approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 13, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0241fbf
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/864e654f-6191-46f1-b543-b23d98570d80

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 13, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bf4f741
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d0b668ae-7156-4038-9dbb-e14d576529c1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini requested review from a team as code owners August 13, 2024 22:35
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 13, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
60.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Cal-L
Cal-L approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini merged commit 72339d1 into main Aug 13, 2024
34 of 35 checks passed
@tommasini tommasini deleted the chore/ts-coverage-ui branch August 13, 2024 23:03
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 13, 2024
@metamaskbot metamaskbot added the release-7.30.0 Issue or pull request that will be included in release 7.30.0 label Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
release-7.30.0 Issue or pull request that will be included in release 7.30.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chore: Typescript type coverage UI Folder part 2 Chore: Typescript type coverage UI Folder part 1
4 participants
@tommasini @codecov-commenter @Cal-L @metamaskbot