fix: Browser dialog prompts in app

[Daniel-Cross]

Description

Added a function that checks to see if the Webview Tab is currently in focus. If the user navigates away from the webview at any point, the app will stop any JS execution in the webview. If the user remains in the webview tab, JS execution will continue as expected.

Related issues

Fixes: Browser Dialog prompts can overlay outside of tab

Manual testing steps

1. Download the following file and visit it in the MM Mobile browser: https://github.com/MetaMask/temp-poc-templates-repo/blob/obs3rv3r-pocs/metamask-poc.html
2. Upon loading the page, switch to another part of the app, such as the settings page or the home page.
3. See that the browser UI prompts still show up over the application
4. Do steps 1-2 again but this time visit another tab in the browser.
5. See that the prompts show up over the other tab

Screenshots/Recordings

Before

After

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-08-21.at.22.44.37.mp4

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: dc69d9d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/29b7371c-241a-4ccd-a9e7-2fac2108b8a8

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a028cda
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/03bad0ab-a0dc-4e20-90f0-1b318f4bebdb

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e024750
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/83f79684-00c5-4f50-95fc-5996638d27db

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ad42703
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8edff0fe-c25e-401b-b649-2f49427d91a6

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 276b154
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/74c9b2e8-0d70-4048-802f-d866c46ca5a0

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.71%. Comparing base (d95e1fc) to head (276b154).
Report is 16 commits behind head on main.

Files	Patch %	Lines
app/components/Views/BrowserTab/index.js	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10540      +/-   ##
==========================================
+ Coverage   52.60%   52.71%   +0.10%     
==========================================
  Files        1530     1533       +3     
  Lines       36709    36802      +93     
  Branches     4313     4338      +25     
==========================================
+ Hits        19312    19399      +87     
+ Misses      16086    16084       -2     
- Partials     1311     1319       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tommasini]

LGTM! After addressing the chain id for hexadecimal values, this looks good to me!

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8c59f7f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/801d0e33-ce8c-49b4-bcd5-9ec9c0366972

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
73.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud