Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add warning banner to custom network bottom sheet #10542

Conversation

EtherWizard33
Copy link
Contributor

@EtherWizard33 EtherWizard33 commented Aug 2, 2024

Description

This small PR adds a banner to the custom network verficition info bottom sheet.
This change is hidden behind the feature flag hiding multichain features.

Related issues

Contributes to solve issue https://github.com/MetaMask/MetaMask-planning/issues/2804

Manual testing steps

from a dapp tab, in the dapp, switch network to a custom network
the bottom sheet seen below will show

Screenshots/Recordings

Before After
Screenshot 2024-04-18 at 3 56 43 PM Screenshot 2024-04-18 at 3 56 43 PM

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux labels Aug 2, 2024
@EtherWizard33 EtherWizard33 requested a review from a team as a code owner August 2, 2024 13:10
Copy link
Contributor

github-actions bot commented Aug 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Aug 2, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 22aeb2c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5d698350-33dc-4627-9065-fd8145edd115

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Aug 2, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 50.61%. Comparing base (d7586ee) to head (22aeb2c).
Report is 1 commits behind head on main.

Files Patch % Lines
...etworkVerificationInfo/NetworkVerificationInfo.tsx 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10542      +/-   ##
==========================================
- Coverage   50.61%   50.61%   -0.01%     
==========================================
  Files        1516     1516              
  Lines       36188    36213      +25     
  Branches     4182     4197      +15     
==========================================
+ Hits        18317    18328      +11     
- Misses      16680    16682       +2     
- Partials     1191     1203      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EtherWizard33 EtherWizard33 merged commit 6622b0f into main Aug 2, 2024
49 checks passed
@EtherWizard33 EtherWizard33 deleted the feat-2804-multichain-custom-network-dapp-connection-confirmation-bottomsheet branch August 2, 2024 13:54
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2024
@metamaskbot metamaskbot added the release-7.30.0 Issue or pull request that will be included in release 7.30.0 label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.30.0 Issue or pull request that will be included in release 7.30.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants