fix: sdk connection issues

[abretonc7s]

Description

• Fixes session error on when reconnecting on existing session (ios).
• Also fixed indirect issue linked to connection stability.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov-commenter]

Codecov Report

Patch coverage: 15.21% and project coverage change: -0.02% ⚠️

Comparison is base (4a224c5) 32.86% compared to head (0506c46) 32.84%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7102      +/-   ##
==========================================
- Coverage   32.86%   32.84%   -0.02%     
==========================================
  Files        1001     1001              
  Lines       26743    26768      +25     
  Branches     2101     2107       +6     
==========================================
+ Hits         8788     8793       +5     
- Misses      17535    17555      +20     
  Partials      420      420              

Files Changed	Coverage Δ
...onents/Views/SDKSessionsManager/SDKSessionItem.tsx	9.52% <0.00%> (-3.81%)	⬇️
app/core/DeeplinkManager.js	1.27% <0.00%> (-0.01%)	⬇️
app/core/SDKConnect/SDKConnect.ts	2.17% <4.16%> (-0.04%)	⬇️
app/core/SDKConnect/utils/wait.util.ts	17.50% <25.00%> (-0.69%)	⬇️
app/util/confirmation/signatureUtils.js	92.30% <100.00%> (+1.39%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[elefantel]

Looks good.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

15.3% Coverage
0.0% Duplication

The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

[elefantel]

Looks good

[christopherferreira9]

Context:
in the flow Connect Dapp -> Approve connection in MMM -> Kill MMM -> Tap sign, the user was being prompt with a connect request instead of the sining prompt. This made that the user would need to approve the connection he did before making it be misleading into making the user think it is a new connection.
The second issue with this is that if the user taps cancel instead of connect in this resuming prompt the connection would be deleted and the Dapp would never know that so the user gets into a stale state.
The third issue occurs with the Signing feedback mentioned here that was indirectly caused by this reconnection flow making the appearance of this toaster forever hidden.

Error Video:

before_bug.mov

Acceptance Criteria:

• After killing the MetaMask Wallet you're able to resume with sign (meaning that the user is able to tap sign on Dapp and get deeplinked to MetaMask)
• After the MetaMask Wallet resumes the user is prompt with the sign approval
• Approving the sign request presents the success message in MetaMask
• Approving the sign request presents the rejection message in MetaMask

SDKs and Dapps tested:

• Android SDK
• Unity SDK
• iOS SDK
• Javascript SDK: Create-React-App; NextJS; ReactNative; ElectronJS; NodeJS

Video Fix for sign on resume:
Uploading ios_fix.mov…

Video fix for the signing feedback:

Screen.Recording.2023-09-04.at.11.27.46.mov