-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add hideSubmitButton
prop to templates
#8844
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGPoyraz
changed the title
Add hideSubmitButton prop to templates
Add Mar 5, 2024
hideSubmitButton
prop to templates
OGPoyraz
changed the title
Add
feat: Add Mar 5, 2024
hideSubmitButton
prop to templateshideSubmitButton
prop to templates
OGPoyraz
added
the
team-confirmations-system
DEPRECATED: please use "team-confirmations" label instead
label
Mar 5, 2024
app/components/Views/confirmations/components/Approval/TemplateConfirmation/Templates/index.ts
Show resolved
Hide resolved
app/components/Views/confirmations/components/Approval/TemplateConfirmation/Templates/index.ts
Outdated
Show resolved
Hide resolved
...onents/Views/confirmations/components/Approval/TemplateConfirmation/TemplateConfirmation.tsx
Outdated
Show resolved
Hide resolved
...onents/Views/confirmations/components/Approval/TemplateConfirmation/TemplateConfirmation.tsx
Outdated
Show resolved
Hide resolved
...onents/Views/confirmations/components/Approval/TemplateConfirmation/TemplateConfirmation.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8844 +/- ##
==========================================
+ Coverage 41.61% 43.27% +1.65%
==========================================
Files 1269 1271 +2
Lines 30869 30916 +47
Branches 3086 3092 +6
==========================================
+ Hits 12846 13378 +532
+ Misses 17246 16765 -481
+ Partials 777 773 -4 ☔ View full report in Codecov by Sentry. |
...onents/Views/confirmations/components/Approval/TemplateConfirmation/TemplateConfirmation.tsx
Outdated
Show resolved
Hide resolved
...onents/Views/confirmations/components/Approval/TemplateConfirmation/TemplateConfirmation.tsx
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
vinistevam
approved these changes
Mar 13, 2024
matthewwalsh0
approved these changes
Mar 13, 2024
metamaskbot
added
the
release-7.19.0
Issue or pull request that will be included in release 7.19.0
label
Mar 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-7.19.0
Issue or pull request that will be included in release 7.19.0
team-confirmations-system
DEPRECATED: please use "team-confirmations" label instead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add
hideSubmitButton
property to confirmation templates. Also hiding action buttons will be possible ifonSubmit
andonCancel
is not provided.Related issues
Fixes: https://github.com/orgs/MetaMask/projects/47/views/1?pane=issue&itemId=55391209
Similar task is resolved in extension MetaMask/metamask-extension#23085
Manual testing steps
To manually test this, either you should add
hideSubmitButton
to true in to your approval request (via code)Or temporarily set
hideSubmitButton
to true in your local atapp/components/Views/confirmations/components/Approval/TemplateConfirmation/Templates/index.ts
values
constant. (See the recorded video by doing this)Screenshots/Recordings
After
HideSubmitButton.in.action.mp4
Pre-merge author checklist
Pre-merge reviewer checklist