Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update transaction controller to v8.0.1 #8866

Merged
merged 15 commits into from
Mar 7, 2024

Conversation

tommasini
Copy link
Contributor

Description

This PR aims to update the transaction controller to version 8.0.1.

The Approval Controller was also updated on this PR to the version of 3.5.0 and approval controller patched was updated.

All the changes are present in this core branch for easy review: patch/mobile-transaction-controller-8-0-1

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

transactions: https://recordit.co/mpcRkPQElC
sign: http://recordit.co/yPI78aEozu

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels Mar 6, 2024
Copy link
Contributor

github-actions bot commented Mar 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Mar 6, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/approval-controller@3.5.0 Transitive: environment, network +24 6.2 MB metamaskbot
npm/@metamask/transaction-controller@8.0.1 Transitive: environment, eval, filesystem, network +130 24.3 MB metamaskbot

🚮 Removed packages: npm/@metamask/approval-controller@3.4.0, npm/@metamask/transaction-controller@7.1.0, npm/zxcvbn@4.4.2

View full report↗︎

Copy link

socket-security bot commented Mar 6, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@tommasini tommasini marked this pull request as ready for review March 6, 2024 17:40
@tommasini tommasini requested a review from a team as a code owner March 6, 2024 17:40
@tommasini tommasini added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 6, 2024
Copy link
Contributor

github-actions bot commented Mar 6, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3a9c12c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b12c95b2-7359-45eb-b633-b9e3f3015d41

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.66%. Comparing base (9cf7630) to head (1bbee9c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8866   +/-   ##
=======================================
  Coverage   41.66%   41.66%           
=======================================
  Files        1271     1271           
  Lines       30906    30906           
  Branches     3088     3088           
=======================================
  Hits        12877    12877           
  Misses      17250    17250           
  Partials      779      779           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 6, 2024
Copy link
Contributor

github-actions bot commented Mar 6, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c52106c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/43c4f6c5-90d3-4084-9e06-d224e0868535

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sleepytanya
Copy link
Contributor

sleepytanya commented Mar 7, 2024

QA build, physical device Samsung s24+, Sepolia, Linea Goerli:

  • Transactions - send native token origin MM
  • Transactions - send native token origin dapp
  • Transactions - send ERC20 token origin MM
  • Transactions - send ERC20 token origin dapp
  • Transactions - send ERC721 token origin MM
  • Transactions - send ERC721 token origin dapp
  • Transactions - speed up transaction
  • Transactions - cancel transaction
  • Tokens - import ERC20 token origin MM
  • Tokens - import ERC20 token origin dapp
  • Tokens - import ERC721 token origin MM (NFT image is not displayed, not related to current PR)
  • Tokens - import ERC721 token origin dapp ('watch NFT', 'watch all NFTs' are not responsive, not related to current branch)
  • Tokens - import ERC1155 token origin MM (image is not displayed)
  • Tokens - import ERC1155 token origin dapp (test dapp 'watch ERC1155 asset' is unresponsive)
  • Tokens - approve ERC1155 token
  • Tokens - approve ERC20 token
  • Tokens - approve ERC721 token
  • ENS - name resolution (works on mainnet only)
  • Gas fee - EIP-1559 gas
  • Gas fee - legacy gas
  • Sign - ETH sign (Blockaid alert)
  • Sign - personal sign
  • Sign - sign in with Ethereum
  • Sign - sign typed with data
  • Permissions - connecting and disconnecting from a dapp
  • Swap - swap eth (skipped, no finds on testing account)
  • Incoming transactions history
  • Custom nonce
  • Cancel transaction using custom nonce
  • Stuck multiple transactions (cancel / speed up)
  • Malformed signatures (alert for 'invalid type' only)
  • PPOM (alert message for 'Malicious ERC20 transfer (USDC)' is not shown)

Base automatically changed from feat/1538-transaction-controller-v7.1 to main March 7, 2024 10:20
matthewwalsh0
matthewwalsh0 previously approved these changes Mar 7, 2024
Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tommasini tommasini merged commit 814e37d into main Mar 7, 2024
28 of 29 checks passed
@tommasini tommasini deleted the feat/1557-transaction-controller-v8.0.1 branch March 7, 2024 11:10
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 7, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.19.0 Issue or pull request that will be included in release 7.19.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants