fix: prevent repeated incoming transaction notifications

[matthewwalsh0]

Description

Update the TransactionController patch to not update the last fetched block number if the new value is lower than the previous one.

This in turn prevents excess incomingTransactionBlock events being emitted which stops the duplicate notifications.

Related issues

Fixes: #8948

Manual testing steps

1. Use account with previous incoming token transfer.
2. Send native balance to same account.
3. Verify incoming transaction notification is shown only once.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.67%. Comparing base (2c29c7f) to head (a8b0f17).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8956   +/-   ##
=======================================
  Coverage   43.67%   43.67%           
=======================================
  Files        1271     1271           
  Lines       30921    30921           
  Branches     3092     3092           
=======================================
  Hits        13506    13506           
  Misses      16636    16636           
  Partials      779      779           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sleepytanya]

QA build, Samsung s24+: notification for incoming transaction shown only once.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a8b0f17
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/642d6b1a-fec6-4239-a0fe-f24d269c20e9

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request