You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fix the #9108 issue,
The keystone relative library used in MM mobile is too old and didnt match the version used in keyring-controller 8.0.1. this PR will upgrade those old keystonehq libraries (try to use as new version as possible) to resolve those keystone QR relative issue.
Scenario: Send using HW account
GIVEN I have Sepolia Test Network selected
AND I have hardware wallet account selected
WHEN I send assets
THEN assets are successfully sent (FAIL: error shown on Confirm screen)
AND send transaction is properly shown on all transactions screen
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
More than one release label on PR. Keeping the lowest one (release-7.20.0) on PR and removing other release labels (release-7.21.0).
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
QA PassedA successful QA run through has been donerelease-7.20.0Issue or pull request that will be included in release 7.20.0release-blockerThis bug is blocking the next releaseRun Smoke E2ETriggers smoke e2e on BitriseSev1-highAn issue that may have caused fund loss or access to wallet in the past & may still be ongoingteam-hardware-wallets
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dawnseeker8
added
release-blocker
chrisleewilcox
added
Run Smoke E2E
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
release-7.21.0
Description
This PR fix the #9108 issue,
The keystone relative library used in MM mobile is too old and didnt match the version used in keyring-controller 8.0.1. this PR will upgrade those old keystonehq libraries (try to use as new version as possible) to resolve those keystone QR relative issue.
Related issues
Fixes: #9108
Manual testing steps
Scenario: Send using HW account
GIVEN I have Sepolia Test Network selected
AND I have hardware wallet account selected
WHEN I send assets
THEN assets are successfully sent (FAIL: error shown on Confirm screen)
AND send transaction is properly shown on all transactions screen
Screenshots/Recordings
Before
Screen.Recording.2024-04-01.at.1.40.50.PM.mov
After
248_1712734345.mp4
Pre-merge author checklist
Pre-merge reviewer checklist