Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused base-64 shim #9617

Closed
wants to merge 1 commit into from
Closed

chore: remove unused base-64 shim #9617

wants to merge 1 commit into from

Conversation

legobeat
Copy link
Contributor

Description

As all runtimes now support atob and btoa, the base-64 shim is not used.

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-security Run Smoke E2E Triggers smoke e2e on Bitrise labels May 13, 2024
@legobeat legobeat marked this pull request as ready for review May 13, 2024 21:29
@legobeat legobeat requested a review from a team as a code owner May 13, 2024 21:29
@socket-security Socket Security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/base-64@1.0.0

View full report↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 13, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a59a811
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/29a8ba7a-d8ab-4366-b25f-cb33bb39217e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 13, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5e58b22
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0675a9ae-a1a2-4ad1-98bc-c4a171e5695e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 13, 2024
@legobeat legobeat marked this pull request as draft May 14, 2024 00:37
@legobeat
Copy link
Contributor Author

legobeat commented May 14, 2024 •
edited
Loading

Not resolved yet in React Native, apparently.

https://github.com/facebook/hermes/issues/1178
https://github.com/reactwg/react-native-releases/issues/287

@legobeat legobeat closed this May 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file Run Smoke E2E Triggers smoke e2e on Bitrise team-security
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@legobeat