This repository has been archived by the owner on Jan 3, 2022. It is now read-only.
Caveat update #127
Merged
Caveat update #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanejonas
approved these changes
Feb 27, 2021
rekmarks
added a commit
that referenced
this pull request
Feb 28, 2021
After merging #127, I realized that I repeated the same mistake I made in #61, which was reverted in #64. The caveat formerly known as `requireParams` enforces that the request parameters are a _superset_ of the caveat value, and that is the intended behavior. That is clearly very confusing for me, so that caveat is now renamed to `requireParamsIsSuperset`. This PR reverts the renaming of the superset caveat done in #127, and creates a new `requireParamsIsSubset` caveat, that actually requires that the request parameters are a subset of the caveat value. Tests have been added.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CaveatTypesenumrequireParamscaveat torequireParamsIsSubsetP.S. My apologies to posterity for the awful commit name.