chore: added version 1.1.2 checksum to versions list for '@metamask/s… #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nap-simple-keyring-snap'
7 tasks
FrederikBolding
approved these changes
Aug 13, 2024
k-g-j
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Aug 13, 2024
#26378) ## **Description** Adds an e2e test where the account Snap suggests the same account name more than once. The expected behavior is that the default account names should have an increasing numeric suffix, e.g.: - SSK Account - SSK Account 2 - SSK Account 3 Dependency: MetaMask/snaps-registry#735 [](https://codespaces.new/MetaMask/metamask-extension/pull/26378?quickstart=1) ## **Related issues** Fixes: https://github.com/MetaMask/accounts-planning/issues/548 ## **Manual testing steps** 1. Install the [Snap Simple Keyring](https://metamask.github.io/snap-simple-keyring/latest/) and connect to the dapp 2. Create an account -> name of 1st account should be "SSK Account" 3. Create more accounts -> 2nd account should be "SSK Account 2" and so forth 4. Try renaming a numbered SSK Account to a higher number, the next account created should be the lowest possible available "SSK Account X" with X being the lowest available number ## **Screenshots/Recordings** https://github.com/user-attachments/assets/b2404a8f-dbe9-468f-9ca3-aac1e028acae ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/26378?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to add a new version of the SSK to the registry