Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files for react-native export compatibility #2451

Merged
merged 2 commits into from
May 31, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented May 31, 2024

@metamask/snaps-controllers has a /react-native export, but React Native seemingly doesn't support exports (or at least the version we use in the mobile repository)? This adds a react-native.js and react-native.d.ts file to support tools that don't support exports.

@Mrtenz Mrtenz requested a review from a team as a code owner May 31, 2024 09:41
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.32%. Comparing base (3431866) to head (aa7dd62).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2451   +/-   ##
=======================================
  Coverage   94.32%   94.32%           
=======================================
  Files         438      438           
  Lines        9021     9021           
  Branches     1382     1382           
=======================================
  Hits         8509     8509           
  Misses        512      512           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@FrederikBolding FrederikBolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to package.json please

@Mrtenz Mrtenz merged commit 0d59bdc into main May 31, 2024
153 checks passed
@Mrtenz Mrtenz deleted the mrtenz/react-native-compatibility branch May 31, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants