Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Defer creation of offscreen document in OffscreenExecutionService #2473

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Jun 10, 2024

Previously, the offscreen document needed to be created from the OffscreenExecutionService because the extension did not do any offscreen set up. Nowadays though, the offscreen document is used by the extension for functionality other than Snaps, and the set up is handled from the extension.

Instead, we the offscreen service now accepts a Promise which should resolve when the offscreen document is ready. The service will wait for the promise to resolve before continuing.

@Mrtenz Mrtenz requested a review from a team as a code owner June 10, 2024 10:02
@Mrtenz Mrtenz force-pushed the mrtenz/remove-offscreen-executor-create-document branch from 576882c to 8661b54 Compare June 13, 2024 09:38
@FrederikBolding
Copy link
Member

@Mrtenz Can you update the PR title and description for the new content? Also should probably be marked as breaking

@Mrtenz Mrtenz changed the title Don't create offscreen document in OffscreenExecutionService Defer creation of offscreen document in OffscreenExecutionService Jun 13, 2024
@Mrtenz Mrtenz changed the title Defer creation of offscreen document in OffscreenExecutionService BREAKING: Defer creation of offscreen document in OffscreenExecutionService Jun 13, 2024
@Mrtenz Mrtenz force-pushed the mrtenz/remove-offscreen-executor-create-document branch from d583e96 to 807deb6 Compare June 13, 2024 09:47
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.34%. Comparing base (caf42e3) to head (807deb6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2473      +/-   ##
==========================================
- Coverage   94.34%   94.34%   -0.01%     
==========================================
  Files         439      439              
  Lines        9057     9054       -3     
  Branches     1392     1391       -1     
==========================================
- Hits         8545     8542       -3     
  Misses        512      512              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mrtenz Mrtenz merged commit 1a3e557 into main Jun 13, 2024
153 checks passed
@Mrtenz Mrtenz deleted the mrtenz/remove-offscreen-executor-create-document branch June 13, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants