chore!: Simplify SVG validation #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
reviewed
Jun 11, 2024
FrederikBolding
changed the title
|
@metamaskbot update-pr |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2475 +/- ##
=======================================
Coverage 94.34% 94.34%
=======================================
Files 438 439 +1
Lines 9054 9055 +1
Branches 1392 1392
=======================================
+ Hits 8542 8543 +1
Misses 512 512 ☔ View full report in Codecov by Sentry. |
Mrtenz
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies SVG validation as we don't need to be as strict as we currently are. This PR moves usage of
fast-xml-parsertosnaps-utils, making Snap bundles smaller and replaces thesvgvalidation struct with a simpler version that doesn't fully parse the SVG.This PR also changes the
Imagestruct to use thesvgstruct to validate its input.Breaking: This removes exported SVG utilities from
snaps-sdk