Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert requiring at least one child #2481

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

FrederikBolding
Copy link
Member

Reverts a change to require at least one child in JSX components that use MaybeArray. This requirement turned out to be too strict and added too much complexity. We will have to deal with the edge-cases it causes instead.

@FrederikBolding FrederikBolding requested a review from a team as a code owner June 12, 2024 10:06
@FrederikBolding
Copy link
Member Author

@metamaskbot update-pr

Mrtenz
Mrtenz previously approved these changes Jun 12, 2024
@FrederikBolding FrederikBolding merged commit 504e4fd into main Jun 12, 2024
151 checks passed
@FrederikBolding FrederikBolding deleted the fb/revert-1-child-requirement branch June 12, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants