new sort added #1368
Merged
new sort added #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabeth-jimenez
requested review from
mjoyce91,
scott062 and
SidelineCory24
Comment on lines
+173
to
174
| { value: 'bidder_bid_submitted_date', text: 'Bid Submitted Date' }, | ||
| // What order do we want these in? |
There was a problem hiding this comment.
I think this order is good as is. Pretty similar to the other sorts ordering given the difference in options.
mjoyce91
reviewed
Feb 17, 2021
Comment on lines
+108
to
+109
| const sort = query.ordering; | ||
| if (sort) { url += `?ordering=${sort}`; } |
There was a problem hiding this comment.
I wouldn't do it this way. Use q to build the params, that way there is no concern of it needing to be ?ordering=${sort} vs &ordering=${sort}
mjoyce91
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'Bid Submitted Date' sort added to Bureau Position Manager Bidder Sort
FE sort updated to integrate with the BE.