Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TM-2729, add modal for custom TOD input #2547

Merged
merged 10 commits into from
May 1, 2023
Merged

TM-2729, add modal for custom TOD input #2547

merged 10 commits into from
May 1, 2023

Conversation

M00staff
Copy link

@M00staff M00staff commented Apr 13, 2023 •
edited
Loading

https://metaphase.atlassian.net/browse/TM-2729

OK

  • add an input and click the plus sign (or hit enter) to add to the custom TOD for that category (TR, RR, HL)
  • on plus, input gets added and clears the text box
  • clear button clears everything
  • OK will add to dropdown

image

image

@M00staff M00staff added the WIP Work in progress label Apr 13, 2023
@M00staff M00staff self-assigned this Apr 13, 2023
@github-actions github-actions bot added size/L and removed size/M labels Apr 18, 2023
@M00staff M00staff changed the title TM-2729, push up POC for discussion and review TM-2729, add modal for custom TOD input Apr 18, 2023
@M00staff M00staff removed the WIP Work in progress label Apr 18, 2023
M00staff
M00staff commented Apr 19, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@M00staff M00staff added the Aging 🧓 No movement on ready-for-review PR in over a week. label Apr 20, 2023
@scott062
Copy link

MVP AC:

  1. Input any variations and repetitions of Tour, RR, and HL
  2. Ability to clear all inputs to start again
  3. Format text using slashes to indicate which category they belong to

@scott062 scott062 added the WIP Work in progress label Apr 24, 2023
@M00staff M00staff removed the WIP Work in progress label Apr 25, 2023
@M00staff
Copy link
Author

@scott062 - looks great, very nice touch ups!

@scott062 scott062 self-requested a review May 1, 2023 19:50
@scott062 scott062 merged commit 7d0d032 into dev May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizabeth-jimenez elizabeth-jimenez elizabeth-jimenez left review comments

@scott062 scott062 scott062 approved these changes

Assignees

@M00staff M00staff

Labels
Aging 🧓 No movement on ready-for-review PR in over a week. Approved size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M00staff @scott062 @elizabeth-jimenez