-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace connect-specific entry points with one global entry point #308
Merged
mars-lan
merged 3 commits into
main
from
marslan/sc-10762/replace-crawler-specific-entry-points-with
Aug 2, 2022
Merged
Replace connect-specific entry points with one global entry point #308
mars-lan
merged 3 commits into
main
from
marslan/sc-10762/replace-crawler-specific-entry-points-with
Aug 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been linked to Shortcut Story #10762: Replace crawler-specific entry points with a global entry point. |
mars-lan
force-pushed
the
marslan/sc-10762/replace-crawler-specific-entry-points-with
branch
from
August 1, 2022 18:09
d1c3cb5
to
7ef7cd6
Compare
mars-lan
changed the title
Replace connect-specific entry point with one global entry point
Replace connect-specific entry points with one global entry point
Aug 1, 2022
elic-eon
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mars-lan
deleted the
marslan/sc-10762/replace-crawler-specific-entry-points-with
branch
August 2, 2022 12:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Why?
To simplify the user experience
Before:
After:
🤓 What?
🧪 Tested?
Built a test Docker image and manually verified all connectors end-to-end.