Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor config for Unity Catalog connector #857

Merged
merged 4 commits into from
May 7, 2024
Merged

Refactor config for Unity Catalog connector #857

merged 4 commits into from
May 7, 2024

Conversation

mars-lan
Copy link
Contributor

@mars-lan mars-lan commented May 6, 2024

🤔 Why?

Refactor the config to support both Databricks cluster & SQL warehouse and to better match Unity Catalog's terminology: https://docs.databricks.com/en/integrations/compute-details.html

🤓 What?

  • Replace host, cluster_path, and warehouse_id with hostname & http_path.
  • Update README files

🧪 Tested?

Verified against a production instance using the new config fields.

☑️ Checks

  • Not bumping up to 0.14 until all breaking changes are merged.

Copy link

github-actions bot commented May 6, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
18929 17771 94% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/unity_catalog/config.py 100% 🟢
metaphor/unity_catalog/extractor.py 96% 🟢
metaphor/unity_catalog/profile/extractor.py 94% 🟢
metaphor/unity_catalog/utils.py 96% 🟢
TOTAL 97% 🟢

updated for commit: df61fa5 by action🐍

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.88%. Comparing base (5944033) to head (df61fa5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
+ Coverage   93.69%   93.88%   +0.18%     
==========================================
  Files         206      163      -43     
  Lines       19121    18929     -192     
==========================================
- Hits        17915    17771     -144     
+ Misses       1206     1158      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mars-lan mars-lan marked this pull request as ready for review May 6, 2024 22:20
@mars-lan mars-lan enabled auto-merge (squash) May 6, 2024 22:20
Copy link
Contributor

@alyiwang alyiwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mars-lan mars-lan merged commit c4e024d into main May 7, 2024
6 checks passed
@mars-lan mars-lan deleted the unity_catalog branch May 7, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants