Add frunk support for swagger::Nullable #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Whitehouse <richard.whitehouse@metaswitch.com>
Signed-off-by: Richard Whitehouse <richard.whitehouse@metaswitch.com>
bossmc
approved these changes
May 4, 2020
Signed-off-by: Richard Whitehouse <richard.whitehouse@metaswitch.com>
Signed-off-by: Richard Whitehouse <richard.whitehouse@metaswitch.com>
|
bors r+ |
|
Build succeeded: |
richardwhiuk
pushed a commit
that referenced
this pull request
May 4, 2020
114: Add frunk support for swagger::Nullable r=richardwhiuk a=richardwhiuk Currently if a OpenAPI model includes a nullable field, we can't use frunk to transmogrify it into a identical structure using `swagger::Nullable` Co-authored-by: Richard Whitehouse <richard.whitehouse@metaswitch.com> Cherry-picked from 36f5300.
bors bot
added a commit
that referenced
this pull request
May 4, 2020
115: Merge #114 to master r=richardwhiuk a=richardwhiuk Forward merge of 114: Add frunk support for swagger::Nullable r=richardwhiuk a=richardwhiuk Currently if a OpenAPI model includes a nullable field, we can't use frunk to transmogrify it into a identical structure using `swagger::Nullable` Co-authored-by: Richard Whitehouse <richard.whitehouse@metaswitch.com> Cherry-picked from 36f5300. Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
richardwhiuk
added a commit
that referenced
this pull request
May 6, 2020
richardwhiuk
added a commit
that referenced
this pull request
May 6, 2020
116: Revert "Add frunk support for swagger::Nullable" r=richardwhiuk a=richardwhiuk This reverts commit 92f6f85. This reverts #114 which caused problems due to lloydmeta/frunk#143 Co-authored-by: Richard Whitehouse <richard.whitehouse@metaswitch.com> Signed-off-by: Richard Whitehouse <richard.whitehouse@metaswitch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a OpenAPI model includes a nullable field, we can't use frunk to transmogrify it into a identical structure using
swagger::Nullable