Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add load function to lazy export minimal package code #430

Merged
merged 5 commits into from
Jul 1, 2022

Conversation

jankapunkt
Copy link
Member

@jankapunkt jankapunkt commented Jun 2, 2021

Table of Contents generated with DocToc

What

Implemented a function Collection2.load that uses a nested import to load all the required functionality. The default export consists only of the EventEmitter instance.

Why

see #394

@jankapunkt jankapunkt linked an issue Jun 2, 2021 that may be closed by this pull request
@jankapunkt jankapunkt mentioned this pull request Jun 2, 2021
@StorytellerCZ
Copy link
Member

Don't forget to update readme. I think this will require major version bump.

@jankapunkt
Copy link
Member Author

Yes this will be breaking IMO. I did not edited in the README anything yet, because I first wanted to know what you and @CaptainN think about this :-)

@harryadel
Copy link
Member

harryadel commented Sep 9, 2021

Sorry for being late @jankapunkt but I'm willing to move forward with this. It's ok to introduce a major version update with new lazy load feature but can we also preserve the old static load type of way? Same way it was done in autoform where they can statically import the package?

@harryadel harryadel mentioned this pull request Sep 17, 2021
@StorytellerCZ StorytellerCZ added this to the v4 milestone Dec 8, 2021
@jankapunkt
Copy link
Member Author

@StorytellerCZ if we have a breaking release with Meteor 2.6, wouldn't it be a good chance to add this now and make a breaking 4.0 release?

@jankapunkt
Copy link
Member Author

@StorytellerCZ @harryadel just getting back at this one. Would this have a chance to be merged when I resolve the conflicts?

@StorytellerCZ
Copy link
Member

@jankapunkt yes, it will become the base for version 4.0

@jankapunkt jankapunkt changed the base branch from master to release-4.0 June 22, 2022 07:35
@jankapunkt
Copy link
Member Author

@StorytellerCZ @harryadel I created a new release-4.0 branch and changed it to be the new base branch

@StorytellerCZ StorytellerCZ mentioned this pull request Jul 1, 2022
3 tasks
@StorytellerCZ StorytellerCZ changed the base branch from release-4.0 to release/v4 July 1, 2022 11:18
@StorytellerCZ StorytellerCZ merged commit eefcdef into release/v4 Jul 1, 2022
@StorytellerCZ StorytellerCZ deleted the lazy-export branch July 1, 2022 11:18
@harryadel
Copy link
Member

I had hoped we can merge this with the ability to import things statically like autoform.

@StorytellerCZ
Copy link
Member

Let's play with this on the v4 branch.

@jankapunkt
Copy link
Member Author

It should work both dynamic and static.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

export lazy
3 participants