-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add load function to lazy export minimal package code #430
Conversation
Don't forget to update readme. I think this will require major version bump. |
Yes this will be breaking IMO. I did not edited in the README anything yet, because I first wanted to know what you and @CaptainN think about this :-) |
Sorry for being late @jankapunkt but I'm willing to move forward with this. It's ok to introduce a major version update with new lazy load feature but can we also preserve the old static load type of way? Same way it was done in autoform where they can statically import the package? |
@StorytellerCZ if we have a breaking release with Meteor 2.6, wouldn't it be a good chance to add this now and make a breaking 4.0 release? |
@StorytellerCZ @harryadel just getting back at this one. Would this have a chance to be merged when I resolve the conflicts? |
@jankapunkt yes, it will become the base for version 4.0 |
@StorytellerCZ @harryadel I created a new |
I had hoped we can merge this with the ability to import things statically like autoform. |
Let's play with this on the v4 branch. |
It should work both dynamic and static. |
Table of Contents generated with DocToc
What
Implemented a function
Collection2.load
that uses a nested import to load all the required functionality. The default export consists only of the EventEmitter instance.Why
see #394