Packetfly module #813
Closed
Packetfly module #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MineGame159
requested changes
May 23, 2021
src/main/java/minegame159/meteorclient/systems/modules/movement/PacketFly.java
Outdated
Show resolved
Hide resolved
|
|
||
| @EventHandler | ||
| public void onPacketSent(PacketEvent.Send event) { | ||
| PlayerMoveC2SPacket packet; |
There was a problem hiding this comment.
I don't see a reason for this field
| @@ -0,0 +1,46 @@ | |||
| package minegame159.meteorclient.utils.misc; | |||
|
|
|||
| public class Timer { | |||
There was a problem hiding this comment.
Please name the methods more descriptively, I have no idea what some of them mean.
MineGame159
reviewed
May 23, 2021
| return false; | ||
| } | ||
|
|
||
| private double[] getMotion(double speed) { |
There was a problem hiding this comment.
Maybe this can be replaced for a method from PlayerUtils class? Not sure but it seems to do similar thing.
MineGame159
requested changes
May 23, 2021
src/main/java/minegame159/meteorclient/systems/modules/movement/PacketFly.java
Show resolved
Hide resolved
|
Also it might be good to group some of the settings into more groups if it makes sense. |
- Entity mixin now checks if entity is player - Moved fields below settings - Removed useless field from onPacketSent - Removed other useless stuff
|
Fixed most of what you suggested, I just need to group the settings now. |
|
Ok, everything should be resolved now |
hashalite
commented
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.