Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError: 'str' object has no attribute 'append' #22

Open
zugaldia opened this issue Jun 8, 2024 · 2 comments
Open

AttributeError: 'str' object has no attribute 'append' #22

zugaldia opened this issue Jun 8, 2024 · 2 comments

Comments

@zugaldia
Copy link

zugaldia commented Jun 8, 2024

Got this error on my packages:

Exception occurred while running check_setup_py: 'str' object has no attribute 'append'
Traceback (most recent call last):
  File "/home/username/.local/bin/glint_ros", line 8, in <module>
    sys.exit(main())
  File "/home/username/.local/lib/python3.10/site-packages/ros_glint/main.py", line 140, in main
    if preview_changes(package, name, fne, len(pkgs) > 1):
  File "/home/username/.local/lib/python3.10/site-packages/ros_glint/main.py", line 77, in preview_changes
    fne(new_pkg)
  File "/home/username/.local/lib/python3.10/site-packages/ros_glint/glinters/python_setup.py", line 149, in check_setup_py
    package.setup_py.args['packages'].append(value)
AttributeError: 'str' object has no attribute 'append'

Packages in the setup.py file looks like this:

packages=find_packages(exclude=["test"]),
@DLu
Copy link
Contributor

DLu commented Jun 18, 2024

Alas, the setup.py parsing is a little more brittle than it could be. Is this a ROS 1 package or ROS 2?

@zugaldia
Copy link
Author

zugaldia commented Jun 18, 2024 via email

DLu added a commit that referenced this issue Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants