fix #345 Disable wrap mouse option if not supported #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we need universal logic for this, i.e. this shouldn't be an exported property. Let's have this logic in settings_menu.gd |
Kiisu-Master
commented
Jan 9, 2024
| @@ -3,7 +3,7 @@ | |||
| [ext_resource type="Script" path="res://src/ui_parts/settings_menu.gd" id="1_1gf4m"] | |||
| [ext_resource type="Texture2D" uid="uid://c528knojuxbw6" path="res://visual/icons/Languages.svg" id="2_ndyp7"] | |||
| [ext_resource type="Script" path="res://src/ui_elements/BetterTabContainer.gd" id="3_vslgx"] | |||
| [ext_resource type="PackedScene" path="res://src/ui_elements/setting_check_box.tscn" id="4_2qeh2"] | |||
| [ext_resource type="PackedScene" uid="uid://chgcy63ldo7x5" path="res://src/ui_elements/setting_check_box.tscn" id="4_2qeh2"] | |||
There was a problem hiding this comment.
idk if i should remove this
There was a problem hiding this comment.
If it happened without you prompting it, don't remove it
|
Thanks! |
MewPurPur
pushed a commit
that referenced
this pull request
Jun 1, 2024
MewPurPur
pushed a commit
that referenced
this pull request
Jun 1, 2024
MewPurPur
pushed a commit
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr does not include separate error message for that yet, im too lazy.
I haven't tested this so i just hope the display server is correct.
hopefully fixes #345
also added back the await in svg because i think its still needed? don't remember anymore but i think that was a issue again