Add file to window title and improve viewport navigation. #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Kiisu-Master
commented
Jan 11, 2024
Kiisu-Master
commented
- Add the currently open file path to the window title.
- Add ctrl + middle mouse zooming.
- Add comments to viewport input handling.
- Change viewport input handling to be else-if cases for event types.
- Add the open file path to the window title. - Add ctrl + middle mouse zooming. - Add comments to viewport input handling. - Change viewport input handling to be else-if cases for event types.
Kiisu-Master
commented
Jan 11, 2024
Comment on lines
+78
to
82
| elif event is InputEventPanGesture: | ||
|
|
||
| # Zooming with ctrl + touch? | ||
| if event.ctrl_pressed: | ||
| zoom_menu.set_zoom(Indications.zoom * (1 + event.delta.y / 2)) |
There was a problem hiding this comment.
Idk what this is
|
Since the logic is under InputEventMouseMotion, can you do this with one of the properties for checking for relative movement instead of with a variable? |
|
The variable is storing the position it will zoom to. |
|
Thanks! |
MewPurPur
pushed a commit
that referenced
this pull request
Jun 1, 2024
MewPurPur
pushed a commit
that referenced
this pull request
Jun 1, 2024
MewPurPur
pushed a commit
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.