Change translation to be on a script basis and add strings automatically #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MewPurPur
changed the title
MewPurPur
force-pushed
the
add-translation-script
branch
6 times, most recently
from
a3db4bc
to
31783e2
Compare
MewPurPur
force-pushed
the
add-translation-script
branch
from
31783e2
to
2b6d933
Compare
MewPurPur
added a commit
that referenced
this pull request
Jun 1, 2024
MewPurPur
added a commit
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #671
Moves all translation-related things to scripts and puts them inside
TranslationServer.translate()commands and similar. In my opinion, this is the best way to handle the issue of gathering everything that should be translated.Important
The way to update translations has changed. Strings don't have to be added manually to GodSVG.pot anymore, but contributors must write code using the
TranslationServer.translate()methods. These methods work regardless of an object's state, so I've blanket-replaced allObject.tr()methods with them.The new way to update strings is to run the
godot_only/update_translations.gdscript inside the Godot editor.There's a new godot_only folder for all things that shouldn't be exported. Right now, that's editor icons for custom classes and the new script for updating strings.