Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please fix issues reported by adapter checker #126

Closed
mcm1957 opened this issue Oct 19, 2023 · 0 comments 路 Fixed by #128
Closed

Please fix issues reported by adapter checker #126

mcm1957 opened this issue Oct 19, 2023 · 0 comments 路 Fixed by #128
Assignees
@MiSchroe

Comments

@mcm1957
Copy link
Contributor

mcm1957 commented Oct 19, 2023

Please fix

馃憖 [W505] setTimeout found in "build/main.js", but no clearTimeout detected

EVERY setTimerout / setInterval MUST be canceled at onOnload as a dangling timer would break compact mode and yield to adapter crashes.

Alternativly you could use uibroker wrapper this.setTimeout instead of setTimeoutwhich will mange this too. This will not remove the warning aas according to good praxis a cancellation should be done anyway. But a look at your code seems to make it easier for you to only use this.setTimeout. I'll ignore the warrning in this case.
@mcm1957 mcm1957 mentioned this issue Oct 19, 2023
Merged
@MiSchroe MiSchroe self-assigned this Oct 19, 2023
MiSchroe pushed a commit that referenced this issue Oct 19, 2023
setTimeout replaced by this.delay
1fd7d63 
Fixes #126
@MiSchroe MiSchroe mentioned this issue Oct 19, 2023
Merged
MiSchroe added a commit that referenced this issue Oct 19, 2023
@MiSchroe
setTimeout replaced by this.delay (#128)
076b259 
* setTimeout replaced by this.delay
Fixes #126

* Updated README

---------

Co-authored-by: Michael Schr枚der <mschroeder@pmone.com>
MiSchroe pushed a commit that referenced this issue Feb 9, 2024
chore: release v1.2.0
ca05b81 
-   (Michael Schroeder) [#126](#126) Fixed Adapter-Checker warning.
-   (Michael Schroeder) [#124](#124) Added help message for password in configuration dialog.
-   (Michael Schroeder) [#106](#106) Fixed an unhandled rejection exception.
-   (Michael Schroeder) [#135](#135) Fixed warning for Admin settings.
-   (Michael Schroeder) [#137](#137) Fixed Github Workflows.
-   (Michael Schroeder) [#40](#40) The scene list can be refreshed.
-   (Michael Schroeder) [#129](#129) The state targetPositionRaw is writable to support additional scenarios.
-   (Michael Schroeder) [#133](#133) Added a refreshProduct state to manually refresh the state of a product.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MiSchroe MiSchroe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

setTimeout replaced by this.delay MiSchroe/ioBroker.klf200
2 participants
@MiSchroe @mcm1957