Change Playground Functionality by Implementing Context and Reducer #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- wrap whole the playground with ManagedLesanContext
- fix mistake in setting of form data - fix type and initial value of response data
|
@hemedani the branch now is ready to review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add functionality to replace all of the playground states with react reducer and context.
I replaced all new reducer functions with the previous state in
src/server/playground/comp/preact.tsxTo use this functionality, we just need to wrap whole the
AppwithManagedLesanContext!The code changes proposed in this pull request aim to resolve the problem mentioned in issue #6 .