-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changement graphique #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est top 🎉 🎉 Juste, il faudra regarder pour les unités. Le pixel n'est pas adapté pour faire du responsive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je pense que cela pourrait être pas-mal de mettre cela en texte dans la légende.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idem
</p> | ||
</div> | ||
|
||
<div id="infos-pts"> | ||
<div> | ||
<h2 id="pt-obs"></h3> | ||
<h3>Qu'observons nous ?</h3> | ||
<p id="what-do-we-see"></p> | ||
<p style="text-align: justify;", id="what-do-we-see"></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Posibilité de simplifier la redondance de définition des styles en ajoutant dans le CSS :
#infos-pts p {
text-align: justify
}
@@ -140,13 +143,21 @@ map.on('load', () => { | |||
map.addLayer({ | |||
"id": "pts", | |||
"type": "circle", | |||
"width": "3px", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Préférer une unité adaptative, genre le %, le pixel ne change pas en fonction de la taille de l'écran
|
||
// Écouteurs d'événements pour les cases à cocher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super ! c'est très lisible.
Petit tips, tu n'es pas obligé de mettre en commentaire le code précédent, dans la mesure où Git permet de garder en mémoire ce code. (il faut éviter au maximum de garder du code commenté)
} | ||
|
||
#infos-pts p { | ||
margin-top: 1%; | ||
font-size: 65%; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rapport à ce que j'ai dit plus haut, tu peux indiquer ici directement :
} | |
text-align: justify | |
} |
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Même remarque sur les pixels
No description provided.