Remove wrongly advertised support for notabug.com, make fetch_gitea_snapshots less expensive and fix fetchFromGitea's fallback behaviour to fetchgit
#244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gogs isn't Gitea. The API surface of Gogs is different from Gitea's. Additionally, notabug.com uses a multiple years old version of Gogs, which has neither `/tags` nor `/commits` implemented. The implementation we use in `version/gitea.py` simple does not work. You can check this yourself by running `nix-update libgtkflow4`, one of the few packages in nixpkgs that are hosted on notabug.com
`fetchFromGitea` just re-uses `fetchFromGitHub`. The only difference is making `domain` a required attribute instead of defaulting to `"github.com"`. As such, it falls back to `fetchgit`, such like `fetchFromGitHub`, if any of the following is true: - fetchSubmodules - leaveDotGit - deepClose - sparseCheckout != [] - forceFetchGit When falling back to `fetchgit`, the `src.url` will end with `".git"`, which we then need to strip again from our parsed `repo` variable. `fetchFromGitHub` has the same logic to trim `".git"` unconditionally.
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at fb5c71b |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the commit messages for details.
Note:
fetchFromGitLabhas the samefetchgitfallback behavior and as such it is also affected by the same issue.