Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DietPi-Software | Add Node.js version 8 as compatibility version #1936

Closed
wants to merge 2 commits into from

Conversation

MichaIng
Copy link
Owner

@MichaIng MichaIng commented Jul 18, 2018

Status: Ready for review and testing

  • VM Jessie, Koel + MineOS
    • Test Node10 installations with Node8 installed: 🈯️ netdata, 🈴 Node-red, 🈴 Blynk, 🈯️ RoonExtentionManager
    • 🈴 Blynk first (🈯️), MineOS afterwards (🈴), gyp ERR! node -v v10.6.0 v10 used, as /usr/local/bin/node (v10) is used before /usr/bin/node (v8). Messy issue with parallel node versions...
  • VM Stretch, Koel + MineOS
  • VM Buster, Koel + MineOS

Reference: https://github.com/Fourdee/DietPi/issues/1880

Commit list/description:

  • DietPi-Software | Add Node.js version 8 as compatibility version for software titles that do not support Node 10 yet

+ DietPi-Software | Add Node.js version 8 as compatibility version for software titles that do not support Node 10 yet
+ DietPi-Software | Initiate aSOFTWARE_REQUIRES_NODEJS8 array as well
@MichaIng
Copy link
Owner Author

Okay having both installations via different install methods in parallel is really messy and leads to fails when installing Node10 dependants while Node8 is installed and the other way round.

Node n while sticking with one install method should be the better solution here. Retest same solution as we currently do with Koel...

@MichaIng
Copy link
Owner Author

Okay, actually it works, with npm install n -g && n 8 when used directly instead of after failure.
The broken build attempt with Node 10 seams to break further build attempts.

I will close this.

@MichaIng MichaIng closed this Jul 18, 2018
@MichaIng MichaIng deleted the NodeJS8 branch July 18, 2018 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant