Remove old support libraries #1522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdk/appcenter/src/main/java/com/microsoft/appcenter/utils/InstrumentationRegistryHelper.java
Outdated
Show resolved
Hide resolved
...src/androidTest/java/com/microsoft/appcenter/persistence/DatabasePersistenceAndroidTest.java
Show resolved
Hide resolved
...pcenter/src/androidTest/java/com/microsoft/appcenter/persistence/PersistenceAndroidTest.java
Show resolved
Hide resolved
...r/src/androidTest/java/com/microsoft/appcenter/utils/storage/DatabaseManagerAndroidTest.java
Show resolved
Hide resolved
MatkovIvan
suggested changes
Mar 31, 2021
| implementation "com.android.support:recyclerview-v7:${rootProject.ext.supportLibVersion}" | ||
| implementation "androidx.appcompat:appcompat:1.0.2" | ||
| implementation "androidx.browser:browser:1.0.0" | ||
| implementation "androidx.recyclerview:recyclerview:1.1.0" |
There was a problem hiding this comment.
Does it mean that all applications that use SDK have to change it? Is it breaking change?
There was a problem hiding this comment.
Nope, these changes need only for the correct passing of our CI steps
AnastasiaKubova
force-pushed
the
fix/remove-old-dependencies
branch
from
61173bc to
02e7ea8
Compare
russelarms
previously approved these changes
Mar 31, 2021
MatkovIvan
suggested changes
Apr 2, 2021
sdk/appcenter/src/main/java/com/microsoft/appcenter/utils/InstrumentationRegistryHelper.java
Outdated
Show resolved
Hide resolved
MatkovIvan
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at our guidelines for contributions and consider the following before you submit the PR:
CHANGELOG.mdbeen updated?Did you add unit tests?Description
Remove old support libraries
Related PRs or issues
AB#85280
#1505