Skip to content

Conversation

AnastasiaKubova
Copy link
Contributor

@AnastasiaKubova AnastasiaKubova commented Apr 5, 2021

Please have a look at our guidelines for contributions and consider the following before you submit the PR:

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you add unit tests?
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?
  • Did you check UI tests on the sample app? They are not executed on CI.

Description

Fix crash during downloading a new release with a specific Gradle configuration.

Repo steps:

  • Create empty app.
  • Add these lines to the app gradle:
release {
    minifyEnabled true
    proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
}
  • Run the app and press on download button on the in-app update dialog.

Expected behavior:
Release successfully downloaded.

Actual behavior:
App crashes.

Related PRs or issues

AB#86011

@AnastasiaKubova AnastasiaKubova force-pushed the fix/crash-download-manager branch from 09e8b85 to 21c5828 Compare April 5, 2021 13:31
@AnastasiaKubova AnastasiaKubova marked this pull request as ready for review April 7, 2021 07:56
Copy link
Contributor

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like invalid fix that affects internal ART validation logic.

As described in the issue, let's modify regular proguard rules instead

@MatkovIvan MatkovIvan merged commit 4063fc7 into develop Apr 8, 2021
@MatkovIvan MatkovIvan deleted the fix/crash-download-manager branch April 8, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants